re-add a warning for old master branch, but with much simpler logic #135301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
instead of calling into git or checking the modification time of files, simply print the warning if there is a very large number of "modified" files. also make the wording much softer, so false positives are less alarming.
lolbinarycat
force-pushed
the
bootstrap-old-master-resurected
branch
from
4288919 to
e1772e7
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
approved these changes
Jan 10, 2025
onur-ozkan
reviewed
Jan 10, 2025
Comment on lines
117
to
119
| if len > 1000 { | ||
| println!("hint: if this number seems too high, try running `git fetch origin master"); | ||
| } |
There was a problem hiding this comment.
I think the if here should include "not a CI" check as we are not interested on this for CI environments.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#134074 (bootstrap: `std::io::ErrorKind::CrossesDevices` is finally stable) - rust-lang#135236 (Update a bunch of library types for MCP807) - rust-lang#135301 (re-add a warning for old master branch, but with much simpler logic) - rust-lang#135324 (Initial fs module for uefi) - rust-lang#135326 (support target specific `optimized-compiler-builtins`) - rust-lang#135347 (Use `NonNull::without_provenance` within the standard library) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2025
Rollup merge of rust-lang#135301 - lolbinarycat:bootstrap-old-master-resurected, r=onur-ozkan re-add a warning for old master branch, but with much simpler logic instead of calling into git or checking the modification time of files, simply print the warning if there is a very large number of "modified" files. also make the wording much softer, so false positives are less alarming. (warning was removed in rust-lang#134935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of calling into git or checking the modification time of files, simply print the warning if there is a very large number of "modified" files.
also make the wording much softer, so false positives are less alarming.
(warning was removed in #134935)